Bug List

Global ClearAllDeletedEntities (void)

if prev pointed to a VALID location higher than a signed int, would still be deleted

Global CreateVaatiApparateManager (VaatiAppearingManager*this, u32 type)

: this always variable points to ROM, not a Manager*

Global DispString (void)

abnormally big width causes tile idx to overwrite other tile attributes

Global LilypadLarge_Action1 (LilypadLargeEntity*)

: tmp could be uninitialized here

Global OctorokGolden (Entity*this)

index (r4) is uninitialized

Global sub_0803901C (CuccoAggrEntity*this)

This if was meant to check r5 instead of r3.

Global sub_0804A044 (Entity*entA, Entity*entB, u32 arg2)

flags & 5 can never equal 0xA

Global sub_08062EDC (Entity*this, ScriptExecutionContext*context)

: tmp is uninitialized, in practice player must have an item here

Global sub_080650CC (StockwellEntity*)

itemPrice (r8) is not initialized if gRoomVars.shopItemType == 0

Global sub_0806AFBC (Entity*this, ScriptExecutionContext*context)

sub_0806B004 uses context but ShowNPCDialogue doesn't pass it.

Global SurfaceAction_CloneTile (PlayerEntity*this)

: n is not initialized

Global Winder_SetPositions (WinderEntity*)

Undefined behaviour for source and destination to overlap in a memcpy. In this case it is okay because the copy will always be sequential, incremental and in chunks of <= 4 bytes, so it will copy the contents of positions[0] and positions[1] to positions[2] and positions[3], then that of positions[2] and positions[3] to positions[4] and positions[5], and so on. A safer way to do this would be a manual loop as in Winder_Move.

Global ZeldaDoLostAnim (NPC5Entity*)

bVar4 (r6) is uninitialized.

Global ZeldaFollowAction (NPC5Entity*)

: r5 is uninitialized